Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] TYPE_CHECKING for MultiModalData #5444

Merged

Conversation

kimdwkimdw
Copy link
Contributor

Small Fix for TYPE_CHECKING for MultiModalData

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 12, 2024 09:14
auto-merge was automatically disabled June 12, 2024 16:58

Base branch was modified

@simon-mo simon-mo merged commit 5cc50a5 into vllm-project:main Jun 12, 2024
101 of 104 checks passed
@kimdwkimdw kimdwkimdw deleted the feature/fix_type_checking_multimodal branch June 13, 2024 05:46
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 16, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants